Differential D14409

Fix start in fancy datepicker calendar
ClosedPublic
Actions

Authored by 0 on Nov 5 2015, 7:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 13, 12:34 AM

	Unknown Object (File)
	Fri, Dec 13, 12:34 AM

	Unknown Object (File)
	Fri, Dec 13, 12:33 AM

	Unknown Object (File)
	Fri, Dec 13, 12:32 AM

	Unknown Object (File)
	Mon, Dec 9, 5:44 AM

	Unknown Object (File)
	Sat, Dec 7, 4:28 AM

	Unknown Object (File)
	Fri, Dec 6, 9:35 PM

	Unknown Object (File)
	Wed, Dec 4, 8:59 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9675: behavior-fancy-datepicker may freeze chrome and firefox when `week start on` set to monday

Commits

Restricted Diffusion Commit
rP9366edf25589: Fix start in fancy datepicker calendar

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

Fixes T9675.
Fixes the calculation for the difference between the first day of the month and the first day of the week. It was previously possible for this to be negative, which caused the subsequent loop to hang the browser.

Test Plan

Set week to start on Sunday. Observed that the calendar still renders fine.
Set week to start on Monday. Observed that the browser no longer hangs on November 2015.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8623
Build 9975: arc lint + arc unit

Event Timeline

0 updated this revision to Diff 34814.Nov 5 2015, 7:20 AM

0 retitled this revision from to Fix start in fancy datepicker calendar.

0 updated this object.

0 edited the test plan for this revision. (Show Details)

0 added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 5 2015, 7:20 AM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: Korvin. · View Herald Transcript

tycho.tatitscheff updated this object.Nov 5 2015, 3:05 PM

tycho.tatitscheff edited edge metadata.

tycho.tatitscheff added a task: T9675: behavior-fancy-datepicker may freeze chrome and firefox when `week start on` set to monday.

epriestley accepted this revision.Nov 5 2015, 3:07 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 5 2015, 3:07 PM

Closed by commit rP9366edf25589: Fix start in fancy datepicker calendar (authored by 0, committed by epriestley). · Explain WhyNov 5 2015, 3:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

webroot/

rsrc/

js/

core/

behavior-fancy-datepicker.js

4 lines

Diff 34814

webroot/rsrc/js/core/behavior-fancy-datepicker.js

Loading...