Page MenuHomePhabricator

Add an alias to Phurl URL's
ClosedPublic

Authored by lpriestley on Nov 3 2015, 6:43 PM.
Tags
None
Referenced Files
F14026523: D14395.id34786.diff
Fri, Nov 8, 1:24 AM
F14026522: D14395.id34778.diff
Fri, Nov 8, 1:24 AM
F14026521: D14395.id34776.diff
Fri, Nov 8, 1:23 AM
F14026520: D14395.id.diff
Fri, Nov 8, 1:23 AM
F14026519: D14395.diff
Fri, Nov 8, 1:23 AM
F14014007: D14395.diff
Sat, Nov 2, 8:39 PM
F14013933: D14395.diff
Sat, Nov 2, 7:55 PM
F14000930: D14395.id34776.diff
Fri, Oct 25, 2:28 AM

Details

Summary

Ref T8992, Add an alias to Phurl URL's that can be used to redirect to link.

Test Plan

Add an alias to Phurl object, and navigate to local.install.com/u/<newalias>. This should redirect to the Phurl's URL.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Add an alias to Phurl URL's.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phurl/controller/PhabricatorPhurlURLAccessController.php
12–20

Indents a little weird?

src/applications/phurl/editor/PhabricatorPhurlURLEditor.php
130

These null should be $xaction, I think.

136

Consider describing permitted characters instead ("...may only contain letters, numbers, hyphens and underscores") so users don't have to guess what "special characters" means.

139

This allows aliases like "--a--a--" and "I_-_-__--" but I suppose those are totally fine.

This revision is now accepted and ready to land.Nov 3 2015, 6:54 PM
lpriestley marked 4 inline comments as done.
lpriestley edited edge metadata.

Updating regex to not allow hyphens and underscores

src/applications/phurl/editor/PhabricatorPhurlURLEditor.php
139

I actually don't think we should accept those.

joshuaspence added inline comments.
src/applications/phurl/application/PhabricatorPhurlApplication.php
33

Hmm, technically /u/(?P<id>[1-9]\d*) will match against this regex as well?

This revision was automatically updated to reflect the committed changes.