Ref T8992, Add an alias to Phurl URL's that can be used to redirect to link.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T8992: Actually implement an `alias` field on Phurl URL's
- Commits
- Restricted Diffusion Commit
rP2b05f7cc43da: Add an alias to Phurl URL's
Add an alias to Phurl object, and navigate to local.install.com/u/<newalias>. This should redirect to the Phurl's URL.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phurlaliases
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8586 Build 9920: Run Core Tests Build 9919: arc lint + arc unit
Event Timeline
| src/applications/phurl/controller/PhabricatorPhurlURLAccessController.php | ||
|---|---|---|
| 12–20 | Indents a little weird? | |
| src/applications/phurl/editor/PhabricatorPhurlURLEditor.php | ||
| 130 | These null should be $xaction, I think. | |
| 136 | Consider describing permitted characters instead ("...may only contain letters, numbers, hyphens and underscores") so users don't have to guess what "special characters" means. | |
| 139 | This allows aliases like "--a--a--" and "I_-_-__--" but I suppose those are totally fine. | |
Comment Actions
Updating regex to not allow hyphens and underscores
| src/applications/phurl/editor/PhabricatorPhurlURLEditor.php | ||
|---|---|---|
| 139 | I actually don't think we should accept those. | |
| src/applications/phurl/application/PhabricatorPhurlApplication.php | ||
|---|---|---|
| 33 | Hmm, technically /u/(?P<id>[1-9]\d*) will match against this regex as well? | |