Page MenuHomePhabricator

Remove some low-hanging buildStandardPageResponse() methods
ClosedPublic

Authored by epriestley on Nov 2 2015, 8:52 PM.
Tags
None
Referenced Files
F15334825: D14385.id34748.diff
Sat, Mar 8, 12:27 PM
F15284568: D14385.diff
Tue, Mar 4, 10:03 AM
Unknown Object (File)
Sat, Feb 8, 11:40 PM
Unknown Object (File)
Sat, Feb 8, 11:40 PM
Unknown Object (File)
Sat, Feb 8, 11:40 PM
Unknown Object (File)
Jan 30 2025, 3:29 PM
Unknown Object (File)
Jan 28 2025, 3:56 AM
Unknown Object (File)
Jan 28 2025, 3:56 AM
Subscribers
None

Details

Summary

Ref T9690. I wanted to do an example of how to do these but it looks like most of them are trivial (no callsites) and the rest are a little tricky (weird interaction with frames, or in Releeph).

Test Plan
  • Used grep to look for callsites.
  • Hit all applications locally, everything worked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove some low-hanging buildStandardPageResponse() methods.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 3 2015, 12:11 AM
This revision was automatically updated to reflect the committed changes.