Page MenuHomePhabricator

Remove some low-hanging buildStandardPageResponse() methods
ClosedPublic

Authored by epriestley on Nov 2 2015, 8:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 3:01 PM
Unknown Object (File)
Thu, Apr 11, 7:12 AM
Unknown Object (File)
Wed, Apr 10, 8:04 PM
Unknown Object (File)
Mon, Apr 8, 2:06 PM
Unknown Object (File)
Tue, Apr 2, 1:29 PM
Unknown Object (File)
Mon, Apr 1, 5:43 PM
Unknown Object (File)
Mon, Apr 1, 12:39 AM
Unknown Object (File)
Sat, Mar 30, 5:41 PM
Subscribers
None

Details

Summary

Ref T9690. I wanted to do an example of how to do these but it looks like most of them are trivial (no callsites) and the rest are a little tricky (weird interaction with frames, or in Releeph).

Test Plan
  • Used grep to look for callsites.
  • Hit all applications locally, everything worked.

Diff Detail

Repository
rP Phabricator
Branch
eengine3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8558
Build 9881: Run Core Tests
Build 9880: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Remove some low-hanging buildStandardPageResponse() methods.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 3 2015, 12:11 AM
This revision was automatically updated to reflect the committed changes.