Probably fix bad URI construction for Diffusion symbols
ClosedPublic
Actions

Authored by epriestley on Oct 20 2015, 3:54 PM.

Details

Reviewers

avivey
chad

Maniphest Tasks

T9532: No symbols found even if they are presented in DB

Commits

Restricted Diffusion Commit
rP4c1463eb569a: Probably fix bad URI construction for Diffusion symbols

Summary

Ref T9532.

Test Plan

I don't have this configured locally but this seems very likely to be the correct fix. This list should be a list of PHIDs, but is a list of PHIDs followed by one PhabricatorRepository object.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34544.Oct 20 2015, 3:54 PM

epriestley retitled this revision from to Probably fix bad URI construction for Diffusion symbols.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, avivey.

epriestley added a task: T9532: No symbols found even if they are presented in DB.

Specifically, T9532#141213 describes the problem I believe this fixes.

chad accepted this revision.Oct 20 2015, 4:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 20 2015, 4:03 PM

Closed by commit rP4c1463eb569a: Probably fix bad URI construction for Diffusion symbols (authored by epriestley, committed by epriestley). · Explain WhyOct 20 2015, 4:03 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T9532: No symbols found even if they are presented in DB.Oct 20 2015, 4:06 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseFileController.php

2 lines

Diff 34548

View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Probably fix bad URI construction for Diffusion symbolsClosedPublicActions