Page MenuHomePhabricator
Differential D14311

Probably fix bad URI construction for Diffusion symbols
ClosedPublic
Actions

Authored by epriestley on Oct 20 2015, 3:54 PM.
Tags
None
Referenced Files
F19510325: D14311.id34548.diff
Sun, Jan 11, 7:36 AM
F19073812: D14311.diff
Dec 1 2025, 3:19 AM
F18992656: D14311.id.diff
Nov 19 2025, 3:45 AM
F18909787: D14311.id.diff
Nov 9 2025, 2:31 AM
F18905167: D14311.diff
Nov 8 2025, 1:08 PM
F18886781: D14311.id34544.diff
Nov 7 2025, 5:06 AM
F18860717: D14311.diff
Nov 2 2025, 12:29 PM
F18814500: D14311.diff
Oct 20 2025, 11:22 PM
View All Files
Subscribers
None

Details

Reviewers
avivey
chad
Maniphest Tasks
T9532: No symbols found even if they are presented in DB
Commits
Restricted Diffusion Commit
rP4c1463eb569a: Probably fix bad URI construction for Diffusion symbols
Summary

Ref T9532.

Test Plan

I don't have this configured locally but this seems very likely to be the correct fix. This list should be a list of PHIDs, but is a list of PHIDs followed by one PhabricatorRepository object.

Diff Detail

Repository
rP Phabricator
Branch
sym1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8356
Build 9590: Run Core Tests
Build 9589: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34544.Oct 20 2015, 3:54 PM
epriestley retitled this revision from to Probably fix bad URI construction for Diffusion symbols.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, avivey.
epriestley added a task: T9532: No symbols found even if they are presented in DB.
epriestley added a comment.Oct 20 2015, 3:56 PM

Specifically, T9532#141213 describes the problem I believe this fixes.

chad accepted this revision.Oct 20 2015, 4:03 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 20 2015, 4:03 PM
Closed by commit rP4c1463eb569a: Probably fix bad URI construction for Diffusion symbols (authored by epriestley, committed by epriestley). · Explain WhyOct 20 2015, 4:03 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T9532: No symbols found even if they are presented in DB.Oct 20 2015, 4:06 PM

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
2 lines

Diff 34544

View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Loading...
Phabricator · Built by Phacility