Ref T9336. Links the timeline photo to user profile. Presume this always exists?
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T9336: Link profile image in feed
- Commits
- Restricted Diffusion Commit
rPf1552f54a056: Link Timeline image to profile
Review a few timelines, click on heads.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- timeline-anchor
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8290 Build 9496: Run Core Tests Build 9495: arc lint + arc unit
Event Timeline
Comment Actions
The only unusual case I can come up with is that I think this will link applications (like "Harbormaster failed to build...", "Herald updated...") to the application base page (/harbormaster/, /herald/). Might be confusing/weird? But doesn't seem too unreasonable to me, really.
Comment Actions
I guess they probably never actually render with user images (although maybe they should since feed stories by them look weird).
Comment Actions
Either I never noticed it before... Or this diff caused avatars to be displayed on desktop notifications