Do not escape binary paths in external linters
AbandonedPublic
Actions

Authored by BYK on Oct 8 2015, 6:14 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

When using external linters, such as puppet-lint the command arc produces is like the following: `"puppet-lint" "something" "some other
thing"`. Note the quotes around the binary name, which breaks the command (at least on Windows). This patch prevents arcanist from escaping the binary
command.

Test Plan

Try arc lint on a project making use of an ExternalLinter on a Windows machine and make sure you see no errors with the patch. Also try
it on a Linux machine and make sure you see no errors on a Linux machine either.

Diff Detail

Repository

rARC Arcanist

Branch

double-escapes

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 8208
Build 9385: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	13 ms	ArcanistChmodLinterTestCase::Unknown Unit Message ("")
	1,043 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	0 ms	ArcanistClosureLinterTestCase::Unknown Unit Message ("")
	0 ms	ArcanistCpplintLinterTestCase::Unknown Unit Message ("")
	26 ms	ArcanistFilenameLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (2 Failed · 24 Passed · 29 Skipped)

Event Timeline

BYK updated this revision to Diff 34395.Oct 8 2015, 6:14 PM

BYK retitled this revision from to Do not escape binary paths in external linters.

BYK updated this object.

BYK edited the test plan for this revision. (Show Details)

BYK added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 8 2015, 6:14 PM

Herald added a subscriber: Korvin. · View Herald Transcript

This is a "does this really work?" sort of diff. Will make it proper after some feedback. Thanks! :)

Fix some tests

This doesn't work: binaries may have spaces in their names. See T8298.

See D11396 for a variant of this. See also T6966. But I don't intend to accept any changes here which are not along the pathway described in T8298 -- that is, I want to build toward a working Windows command escaping environment, not pile more hacks on the broken one we have now.