Improve external linter robustness on Windows
AbandonedPublic
Actions

Authored by staticshock on Jan 14 2015, 8:03 PM.

Tags

None

Referenced Files

	F18971426: D11396.diff
	Nov 15 2025, 11:42 AM

	F18942035: D11396.id.diff
	Nov 11 2025, 11:32 AM

	F18939569: D11396.diff
	Nov 11 2025, 6:57 AM

	F18839181: D11396.diff
	Oct 27 2025, 2:53 PM

	F18818668: D11396.id.diff
	Oct 22 2025, 1:39 AM

	F18711987: D11396.diff
	Sep 29 2025, 5:12 AM

	F18652941: D11396.id.diff
	Sep 21 2025, 10:19 AM

	F18649088: D11396.id27369.diff
	Sep 20 2025, 6:58 PM

View All Files

Subscribers

epriestley

joshuaspence

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6966: Windows quoting conventions still bad

Summary

Fixes T6966

Test Plan

Ran jshint linter on Windows. Saw actual linter output.

Diff Detail

Repository

rARC Arcanist

Branch

cmd-quote

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3849
Build 3861: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

staticshock updated this revision to Diff 27369.Jan 14 2015, 8:03 PM

staticshock retitled this revision from to Improve external linter robustness on Windows.

staticshock updated this object.

staticshock edited the test plan for this revision. (Show Details)

staticshock added a task: T6966: Windows quoting conventions still bad.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 14 2015, 8:03 PM

Herald added a subscriber: epriestley. · View Herald Transcript

joshuaspence added a subscriber: joshuaspence.Feb 27 2015, 5:53 AM

epriestley mentioned this in D14246: Do not escape binary paths in external linters.Oct 8 2015, 7:26 PM

epriestley mentioned this in T8298: Fix Windows Escaping.Oct 8 2015, 7:36 PM

See T8298. I don't plan to bring this or any other hacky workarounds upstream.

This revision now requires changes to proceed.Nov 23 2015, 4:15 PM

staticshock abandoned this revision.Nov 25 2015, 4:19 AM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistExternalLinter.php

4 lines

Diff 27369

View Options

src/lint/linter/ArcanistExternalLinter.php

Improve external linter robustness on WindowsAbandonedPublicActions