When using external linters, such as puppet-lint the command arc produces is like the following: `"puppet-lint" "something" "some other
thing"`. Note the quotes around the binary name, which breaks the command (at least on Windows). This patch prevents arcanist from escaping the binary
command.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers
Try arc lint on a project making use of an ExternalLinter on a Windows machine and make sure you see no errors with the patch. Also try
it on a Linux machine and make sure you see no errors on a Linux machine either.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- double-escapes
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 8207 Build 9384: arc lint + arc unit
Event Timeline
Comment Actions
This is a "does this really work?" sort of diff. Will make it proper after some feedback. Thanks! :)
Comment Actions
This doesn't work: binaries may have spaces in their names. See T8298.
See D11396 for a variant of this. See also T6966. But I don't intend to accept any changes here which are not along the pathway described in T8298 -- that is, I want to build toward a working Windows command escaping environment, not pile more hacks on the broken one we have now.