When using external linters, such as puppet-lint the command arc produces is like the following: `"puppet-lint" "something" "some other
thing"`. Note the quotes around the binary name, which breaks the command (at least on Windows). This patch prevents arcanist from escaping the binary
command.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers
Try arc lint on a project making use of an ExternalLinter on a Windows machine and make sure you see no errors with the patch. Also try
it on a Linux machine and make sure you see no errors on a Linux machine either.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- double-escapes
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 8207 Build 9384: arc lint + arc unit
Time | Test | |
---|---|---|
15 ms | ArcanistChmodLinterTestCase::Unknown Unit Message (" |