Differential D14225

Set name on more linters
ClosedPublic
Actions

Authored by vm on Oct 2 2015, 3:57 PM.

Tags

None

Referenced Files

	F15453089: D14225.diff
	Sat, Mar 29, 9:18 AM

	F15450740: D14225.diff
	Fri, Mar 28, 5:53 PM

	F15391219: D14225.diff
	Sat, Mar 15, 8:48 AM

	F15389620: D14225.diff
	Sat, Mar 15, 5:30 AM

	F15385432: D14225.id34349.diff
	Fri, Mar 14, 10:35 PM

	F15335283: D14225.diff
	Sat, Mar 8, 3:01 PM

	F15331777: D14225.id34350.diff
	Fri, Mar 7, 1:35 PM

	Unknown Object (File)
	Feb 19 2025, 4:02 AM

Subscribers

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Commits

rARC742327128f4e: (stable) Promote 2015 Week 40
rARC1b4a3e0c5eb9: Set path on more linters

Summary

This is in a similar vein as D14220 and sets a name on linter
messages. This should handle issues from D14165.

Test Plan

Run as many of the changed linters as possible + existing linter tests.

Diff Detail

Repository

Branch

fix_more_linters

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 8157
Build 9318: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	168 ms	ArcanistCppcheckLinterTestCase::Unknown Unit Message ("")
	138 ms	ArcanistCpplintLinterTestCase::Unknown Unit Message ("")
	870 ms	ArcanistJSHintLinterTestCase::Unknown Unit Message ("")
	1,528 ms	ArcanistJscsLinterTestCase::Unknown Unit Message ("")
	399 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (4 Failed · 36 Passed · 15 Skipped)

Event Timeline

vm updated this revision to Diff 34349.Oct 2 2015, 3:57 PM

vm retitled this revision from to Set path on more linters.

vm updated this object.

vm edited the test plan for this revision. (Show Details)

vm added a reviewer: epriestley.

Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptOct 2 2015, 3:57 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Oct 2 2015, 3:58 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 2 2015, 3:58 PM

Closed by commit rARC1b4a3e0c5eb9: Set path on more linters (authored by vm, committed by epriestley). · Explain WhyOct 2 2015, 3:58 PM

This revision was automatically updated to reflect the committed changes.

vm retitled this revision from Set path on more linters to Set name on more linters.Oct 2 2015, 4:10 PM

vm edited edge metadata.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistCSSLintLinter.php

1 line

ArcanistGoLintLinter.php

1 line

ArcanistJSONLintLinter.php

1 line

ArcanistJscsLinter.php

1 line

ArcanistPyFlakesLinter.php

1 line

Diff 34349

src/lint/linter/ArcanistCSSLintLinter.php

Loading...

src/lint/linter/ArcanistGoLintLinter.php

Loading...

src/lint/linter/ArcanistJSONLintLinter.php

Loading...

src/lint/linter/ArcanistJscsLinter.php

Loading...

src/lint/linter/ArcanistPyFlakesLinter.php

Loading...