Page MenuHomePhabricator
Differential D14220

Fix ArcanistClosureLinter
ClosedPublic
Actions

Authored by vm on Oct 2 2015, 3:30 AM.

Details

Reviewers
joshuaspence
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9498: ArcanistClosureLinter broken after D14165
Commits
rARCf0c57986bc32: Fix ArcanistClosureLinter
Summary

Fixes T9498

Test Plan

Run arc lint with errors that get caught and reported by ArcanistClosureLinter

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vm updated this revision to Diff 34338.Oct 2 2015, 3:30 AM
vm retitled this revision from to Fix ArcanistClosureLinter.
vm updated this object.
vm edited the test plan for this revision. (Show Details)
vm added a reviewer: epriestley.
vm added a task: T9498: ArcanistClosureLinter broken after D14165.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 2 2015, 3:30 AM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence added a reviewer: joshuaspence.Oct 2 2015, 8:31 AM
epriestley accepted this revision.Oct 2 2015, 12:45 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 2 2015, 12:45 PM
Closed by commit rARCf0c57986bc32: Fix ArcanistClosureLinter (authored by vm, committed by epriestley). · Explain WhyOct 2 2015, 12:45 PM
This revision was automatically updated to reflect the committed changes.
vm mentioned this in D14225: Set name on more linters.Oct 2 2015, 3:57 PM
epriestley mentioned this in rARC1b4a3e0c5eb9: Set path on more linters.Oct 2 2015, 3:58 PM

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
1 line

Diff 34343

View Options

src/lint/linter/ArcanistClosureLinter.php

Loading...
Phabricator · Built by Phacility