Page MenuHomePhabricator
Differential D14220

Fix ArcanistClosureLinter
ClosedPublic
Actions

Authored by vm on Oct 2 2015, 3:30 AM.
Tags
None
Referenced Files
F15450752: D14220.diff
Fri, Mar 28, 6:01 PM
F15424395: D14220.id.diff
Sat, Mar 22, 10:01 PM
F15391222: D14220.diff
Sat, Mar 15, 8:50 AM
F15331386: D14220.id34338.diff
Fri, Mar 7, 9:49 AM
F15316704: D14220.id.diff
Thu, Mar 6, 6:55 PM
Unknown Object (File)
Feb 26 2025, 1:21 PM
Unknown Object (File)
Feb 19 2025, 4:06 AM
Unknown Object (File)
Feb 19 2025, 4:05 AM
View All Files
Subscribers
Korvin

Details

Reviewers
joshuaspence
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9498: ArcanistClosureLinter broken after D14165
Commits
rARCf0c57986bc32: Fix ArcanistClosureLinter
Summary

Fixes T9498

Test Plan

Run arc lint with errors that get caught and reported by ArcanistClosureLinter

Diff Detail

Repository
rARC Arcanist
Branch
fix_closure_linter
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 8146
Build 9302: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
159 msArcanistCppcheckLinterTestCase::Unknown Unit Message ("")
138 msArcanistCpplintLinterTestCase::Unknown Unit Message ("")
891 msArcanistJSHintLinterTestCase::Unknown Unit Message ("")
661 msArcanistJSONLintLinterTestCase::Unknown Unit Message ("")
146 msArcanistPyFlakesLinterTestCase::Unknown Unit Message ("")
View Full Test Results (5 Failed · 31 Passed · 19 Skipped)

Event Timeline

vm updated this revision to Diff 34338.Oct 2 2015, 3:30 AM
vm retitled this revision from to Fix ArcanistClosureLinter.
vm updated this object.
vm edited the test plan for this revision. (Show Details)
vm added a reviewer: epriestley.
vm added a task: T9498: ArcanistClosureLinter broken after D14165.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 2 2015, 3:30 AM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence added a reviewer: joshuaspence.Oct 2 2015, 8:31 AM
epriestley accepted this revision.Oct 2 2015, 12:45 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 2 2015, 12:45 PM
Closed by commit rARCf0c57986bc32: Fix ArcanistClosureLinter (authored by vm, committed by epriestley). · Explain WhyOct 2 2015, 12:45 PM
This revision was automatically updated to reflect the committed changes.
vm mentioned this in D14225: Set name on more linters.Oct 2 2015, 3:57 PM
epriestley mentioned this in rARC1b4a3e0c5eb9: Set path on more linters.Oct 2 2015, 3:58 PM

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
1 line

Diff 34338

View Options

src/lint/linter/ArcanistClosureLinter.php

Loading...
Phabricator · Built by Phacility