Paths

Table of Contentst

Differential D14220

Fix ArcanistClosureLinter
ClosedPublic
Actions

Authored by vm on Oct 2 2015, 3:30 AM.

Tags

None

Referenced Files

	F18085240: D14220.diff
	Tue, Aug 5, 7:04 PM

	F18049417: D14220.id.diff
	Sun, Aug 3, 4:11 PM

	F18003364: D14220.diff
	Sat, Aug 2, 11:20 AM

	F17941438: D14220.id.diff
	Thu, Jul 31, 5:27 AM

	F17938480: D14220.diff
	Thu, Jul 31, 2:15 AM

	Unknown Object (File)
	Jul 3 2025, 7:54 AM

	Unknown Object (File)
	Jun 1 2025, 9:51 AM

	Unknown Object (File)
	May 31 2025, 6:18 AM

Subscribers

Details

Reviewers

joshuaspence
epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9498: ArcanistClosureLinter broken after D14165

Commits

rARCf0c57986bc32: Fix ArcanistClosureLinter

Summary

Fixes T9498

Test Plan

Run arc lint with errors that get caught and reported by ArcanistClosureLinter

Diff Detail

Repository

Branch

fix_closure_linter

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 8146
Build 9302: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	159 ms	ArcanistCppcheckLinterTestCase::Unknown Unit Message ("")
	138 ms	ArcanistCpplintLinterTestCase::Unknown Unit Message ("")
	891 ms	ArcanistJSHintLinterTestCase::Unknown Unit Message ("")
	661 ms	ArcanistJSONLintLinterTestCase::Unknown Unit Message ("")
	146 ms	ArcanistPyFlakesLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (5 Failed · 31 Passed · 19 Skipped)

Event Timeline

vm updated this revision to Diff 34338.Oct 2 2015, 3:30 AM

vm retitled this revision from to Fix ArcanistClosureLinter.

vm updated this object.

vm edited the test plan for this revision. (Show Details)

vm added a reviewer: epriestley.

vm added a task: T9498: ArcanistClosureLinter broken after D14165.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 2 2015, 3:30 AM

Herald added a subscriber: Korvin. · View Herald Transcript

joshuaspence added a reviewer: joshuaspence.Oct 2 2015, 8:31 AM

epriestley accepted this revision.Oct 2 2015, 12:45 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 2 2015, 12:45 PM

Closed by commit rARCf0c57986bc32: Fix ArcanistClosureLinter (authored by vm, committed by epriestley). · Explain WhyOct 2 2015, 12:45 PM

This revision was automatically updated to reflect the committed changes.

vm mentioned this in D14225: Set name on more linters.Oct 2 2015, 3:57 PM

epriestley mentioned this in rARC1b4a3e0c5eb9: Set path on more linters.Oct 2 2015, 3:58 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistClosureLinter.php

1 line

Diff 34338

src/lint/linter/ArcanistClosureLinter.php

Loading...