Page MenuHomePhabricator

Add staging area support to Harbormaster/Drydock + various fixes
ClosedPublic

Authored by epriestley on Oct 1 2015, 6:21 PM.
Tags
None
Referenced Files
F13231861: D14214.diff
Tue, May 21, 12:49 AM
F13226670: D14214.id34333.diff
Sun, May 19, 10:22 PM
F13214669: D14214.id.diff
Fri, May 17, 12:19 PM
F13186464: D14214.diff
Sat, May 11, 3:39 AM
Unknown Object (File)
Tue, May 7, 6:55 AM
Unknown Object (File)
Sat, May 4, 4:30 PM
Unknown Object (File)
Fri, May 3, 4:34 AM
Unknown Object (File)
Thu, Apr 25, 12:37 AM
Subscribers
None
Tokens
"Love" token, awarded by avivey."Love" token, awarded by johnny-bit.

Details

Summary

Ref T9252. This primarily allows Harbormaster to request (and Drydock to fulfill) working copies with a patch from a staging area. Doing this means we can do builds on in-review changes from arc diff.

This is a little cobbled-together but should basically work.

Also fix some other issues:

  • Yielded, awakend workers are fine to update but could complain.
  • We can't log slot lock failures to resources if we don't end up saving them.
  • Killing the transaction would wipe out the log.
  • Fix some TODOs, etc.
Test Plan

Ran Harbormaster builds on a local revision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add staging area support to Harbormaster/Drydock + various fixes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, hach-que.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 1 2015, 8:31 PM
This revision was automatically updated to reflect the committed changes.