Page MenuHomePhabricator

Add staging area support to Harbormaster/Drydock + various fixes
ClosedPublic

Authored by epriestley on Oct 1 2015, 6:21 PM.
Tags
None
Referenced Files
F19027010: D14214.id.diff
Mon, Nov 24, 1:05 PM
F18827284: D14214.id34333.diff
Oct 24 2025, 9:03 AM
F18781488: D14214.diff
Oct 12 2025, 10:42 PM
F18766079: D14214.id.diff
Oct 7 2025, 2:51 PM
F18650916: D14214.id34333.diff
Sep 21 2025, 2:16 AM
F18648635: D14214.id.diff
Sep 20 2025, 4:34 PM
F18626347: D14214.diff
Sep 16 2025, 1:05 AM
F18617164: D14214.id34327.diff
Sep 14 2025, 8:27 PM
Subscribers
None
Tokens
"Love" token, awarded by avivey."Love" token, awarded by johnny-bit.

Details

Summary

Ref T9252. This primarily allows Harbormaster to request (and Drydock to fulfill) working copies with a patch from a staging area. Doing this means we can do builds on in-review changes from arc diff.

This is a little cobbled-together but should basically work.

Also fix some other issues:

  • Yielded, awakend workers are fine to update but could complain.
  • We can't log slot lock failures to resources if we don't end up saving them.
  • Killing the transaction would wipe out the log.
  • Fix some TODOs, etc.
Test Plan

Ran Harbormaster builds on a local revision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add staging area support to Harbormaster/Drydock + various fixes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, hach-que.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 1 2015, 8:31 PM
This revision was automatically updated to reflect the committed changes.