Page MenuHomePhabricator

Move commits to the "COMMIT" mail prefix
ClosedPublic

Authored by epriestley on Sep 25 2015, 3:01 PM.
Tags
None
Referenced Files
F13147688: D14163.diff
Fri, May 3, 3:29 PM
Unknown Object (File)
Fri, May 3, 10:18 AM
Unknown Object (File)
Thu, Apr 25, 3:45 AM
Unknown Object (File)
Fri, Apr 19, 3:38 PM
Unknown Object (File)
Tue, Apr 16, 9:19 AM
Unknown Object (File)
Tue, Apr 16, 6:29 AM
Unknown Object (File)
Mon, Apr 8, 1:32 PM
Unknown Object (File)
Mar 30 2024, 4:39 PM
Subscribers
None

Details

Summary

Fixes T9427. Currently, replies to audits/commits go to "Cxxx", but so do replies to countdowns.

There is non real non-disruptive approach available here and this seems least-bad.

Test Plan
  • Made a comment on a commit.
  • Fished the reply-to address out of bin/mail list-oubound + bin/mail show-outbound (it was now "COMMIT...").
  • Sent mail to that address.
  • Grabbed the raw message and wrote it to mail.txt.
  • Ran cat mail.txt | ./scripts/mail/mail_handler.php --process-duplicates.
  • Used bin/mail list-inbound + bin/mail show-inbound to verify receipt.
  • Saw comment appear on audit.

Diff Detail

Repository
rP Phabricator
Branch
commit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8054
Build 9142: [Placeholder Plan] Wait for 30 Seconds
Build 9141: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Move commits to the "COMMIT" mail prefix.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.EditedSep 25 2015, 3:12 PM
chad edited edge metadata.

There is non real non-disruptive approach available here and this seems least-bad.

wut

This revision is now accepted and ready to land.Sep 25 2015, 3:12 PM

Oh, haha.

There is non real non

Should be "There is no real non-disruptive...": we have to break something since the current state of the world doesn't work.

This revision was automatically updated to reflect the committed changes.