Page MenuHomePhabricator
Differential D14085

update linter short desc
ClosedPublic
Actions

Authored by avivey on Sep 8 2015, 7:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 10, 3:29 AM
Unknown Object (File)
Sat, Feb 8, 11:13 PM
Unknown Object (File)
Sat, Feb 8, 11:13 PM
Unknown Object (File)
Sat, Feb 8, 11:13 PM
Unknown Object (File)
Sat, Feb 8, 11:13 PM
Unknown Object (File)
Thu, Feb 6, 4:05 PM
Unknown Object (File)
Thu, Feb 6, 4:04 PM
Unknown Object (File)
Tue, Feb 4, 3:35 AM
View All Files
Subscribers
joshuaspence
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9353: make arc linters one-line output more informative
Commits
rARC316858315950: (stable) Promote 2015 Week 37
rARC28b89785fe5f: update linter short desc
Summary

ref T9353.

Test Plan

arc linters

Diff Detail

Repository
rARC Arcanist
Branch
linters
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7946
Build 8921: [Placeholder Plan] Wait for 30 Seconds
Build 8920: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 34036.Sep 8 2015, 7:55 PM
avivey retitled this revision from to update linter short desc.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added a reviewer: epriestley.
avivey added a task: T9353: make arc linters one-line output more informative.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 8 2015, 7:55 PM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence added a subscriber: joshuaspence.Sep 8 2015, 8:39 PM
epriestley accepted this revision.Sep 8 2015, 8:45 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 8 2015, 8:45 PM
epriestley added a comment.Sep 8 2015, 8:49 PM

You should have commit access now if you want to land this yourself.

avivey added a comment.Sep 8 2015, 8:50 PM

Whoo, thanks!

joshuaspence added inline comments.Sep 8 2015, 8:52 PM
src/lint/linter/ArcanistJSHintLinter.php
12

I find this not very informative, it doesn't mention JSHint at all

avivey added inline comments.Sep 8 2015, 8:54 PM
src/lint/linter/ArcanistJSHintLinter.php
12

in arc linters it looks like:

AVAILABLE   jshint (JavaScript error checking)

ie, the name is always there anyway.

joshuaspence added a comment.Sep 8 2015, 9:40 PM

Ah, all good then!

Closed by commit rARC28b89785fe5f: update linter short desc (authored by avivey, committed by avivey). · Explain WhySep 8 2015, 9:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 34036

View Options

src/lint/linter/ArcanistComposerLinter.php

Loading...
View Options

src/lint/linter/ArcanistCppcheckLinter.php

Loading...
View Options

src/lint/linter/ArcanistCpplintLinter.php

Loading...
View Options

src/lint/linter/ArcanistFlake8Linter.php

Loading...
View Options

src/lint/linter/ArcanistHLintLinter.php

Loading...
View Options

src/lint/linter/ArcanistJSHintLinter.php

Loading...
View Options

src/lint/linter/ArcanistJscsLinter.php

Loading...
View Options

src/lint/linter/ArcanistPyFlakesLinter.php

Loading...
View Options

src/lint/linter/ArcanistRuboCopLinter.php

Loading...
Phabricator · Built by Phacility