Page MenuHomePhabricator
Differential D14076

Allow upgrading in branch `stable`
ClosedPublic
Actions

Authored by avivey on Sep 7 2015, 6:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 8:18 AM
Unknown Object (File)
Sat, Nov 9, 10:06 AM
Unknown Object (File)
Sat, Nov 9, 10:06 AM
Unknown Object (File)
Sat, Nov 9, 10:06 AM
Unknown Object (File)
Sat, Nov 9, 10:06 AM
Unknown Object (File)
Sat, Nov 9, 10:06 AM
Unknown Object (File)
Fri, Nov 8, 8:42 PM
Unknown Object (File)
Fri, Nov 8, 8:42 PM
View All Files
Subscribers
cburroughs
epriestley
Tokens
"Doubloon" token, awarded by epriestley.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9043: `arc upgrade` does not work with stable branches
Commits
rARC8f3a002cdb19: Allow upgrading in branch `stable`
Summary

close T9043. This still allows for one dir to be in master and the other in stable, but hopefully that's not going to be a problem.

Test Plan

Clone arc/libph, checkout stable, run arc upgrade.

Diff Detail

Repository
rARC Arcanist
Branch
arcpatch-D14076
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7936
Build 8901: [Placeholder Plan] Wait for 30 Seconds
Build 8900: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 34018.Sep 7 2015, 6:43 PM
avivey retitled this revision from to Allow upgrading in branch `stable`.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added a task: T9043: `arc upgrade` does not work with stable branches.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 7 2015, 6:43 PM
Herald added a subscriber: epriestley. · View Herald Transcript
avivey updated this revision to Diff 34019.Sep 7 2015, 6:46 PM
avivey edited edge metadata.

Actually look at error message this time.

cburroughs added a subscriber: cburroughs.Sep 7 2015, 7:28 PM
cburroughs added inline comments.
src/workflow/ArcanistUpgradeWorkflow.php
57–58

This comment should probably be updated along with the change.

avivey added inline comments.Sep 7 2015, 8:00 PM
src/workflow/ArcanistUpgradeWorkflow.php
57–58

I think I'll just delete it, since it's outlived its usefulness.

avivey updated this revision to Diff 34022.Sep 7 2015, 8:06 PM

Remove code comments

avivey marked an inline comment as done.Sep 7 2015, 8:07 PM
epriestley accepted this revision.Sep 7 2015, 8:44 PM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Sep 7 2015, 8:44 PM
epriestley awarded a token.Sep 7 2015, 8:44 PM
Closed by commit rARC8f3a002cdb19: Allow upgrading in branch `stable` (authored by avivey, committed by epriestley). · Explain WhySep 7 2015, 8:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
workflow/
8 lines

Diff 34022

View Options

src/workflow/ArcanistUpgradeWorkflow.php

Loading...
Phabricator · Built by Phacility