Page MenuHomePhabricator
Differential D14030

Remove errant in arcanist.php
ClosedPublic
Actions

Authored by yelirekim on Sep 1 2015, 3:10 PM.
Tags
None
Referenced Files
F15180290: D14030.diff
Wed, Feb 19, 6:52 PM
Unknown Object (File)
Tue, Feb 11, 1:23 PM
Unknown Object (File)
Sat, Feb 8, 11:09 PM
Unknown Object (File)
Sat, Feb 8, 5:41 AM
Unknown Object (File)
Sat, Feb 8, 5:41 AM
Unknown Object (File)
Mon, Feb 3, 12:23 AM
Unknown Object (File)
Thu, Jan 30, 1:32 PM
Unknown Object (File)
Sun, Jan 26, 2:50 PM
View All Files
Subscribers
epriestley
joshuaspence
• wasimsikder2013

Details

Reviewers
epriestley
• facebook.noreply.php
Group Reviewers
Blessed Reviewers
Commits
rARCde7a999ce918: Remove errant in arcanist.php
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

This causes 49 to be printed out preceding the start of my next terminal line every time there is an exception thrown.

Test Plan

did not see 49 printed out when exceptions were thrown

Diff Detail

Repository
rARC Arcanist
Branch
echo_49
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7874
Build 8779: [Placeholder Plan] Wait for 30 Seconds
Build 8778: arc lint + arc unit

Event Timeline

yelirekim updated this revision to Diff 33921.Sep 1 2015, 3:10 PM
yelirekim retitled this revision from to Remove errant in arcanist.php.
yelirekim updated this object.
yelirekim edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 1 2015, 3:10 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley accepted this revision.Sep 1 2015, 3:45 PM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Sep 1 2015, 3:45 PM
Closed by commit rARCde7a999ce918: Remove errant in arcanist.php (authored by yelirekim, committed by epriestley). · Explain WhySep 1 2015, 3:46 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Sep 1 2015, 3:46 PM

49

• wasimsikder2013 added a reviewer: • facebook.noreply.php.Sep 1 2015, 6:32 PM
• wasimsikder2013 added a subscriber: • wasimsikder2013.

Good

joshuaspence added a subscriber: joshuaspence.Sep 1 2015, 10:01 PM

Out of curiosity, how was this diff accepted without L28 being signed? Is this a bug?

joshuaspence added a comment.Sep 1 2015, 10:01 PM
This comment was removed by joshuaspence.
epriestley added a comment.Sep 1 2015, 10:12 PM

It was signed -- that's the signed state. I suppose we could put a green checkmark next to it or something.

joshuaspence added a comment.Sep 1 2015, 10:13 PM

Ah right, so the Required Signatures row doesn't go away after signing?

epriestley added a comment.Sep 1 2015, 10:14 PM

Yeah, it's like red or yellow or something before you sign I think and then just normal after you sign.

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

PathSize
scripts/
2 lines

Diff 33921

View Options

scripts/arcanist.php

Loading...
Phabricator · Built by Phacility