Page MenuHomePhabricator
Differential D14014

Prevent users from hiding unpublished inlines
ClosedPublic
Actions

Authored by epriestley on Aug 31 2015, 1:48 PM.
Tags
None
Referenced Files
F14738959: D14014.diff
Sun, Jan 19, 5:42 PM
Unknown Object (File)
Fri, Jan 17, 9:53 AM
Unknown Object (File)
Wed, Jan 1, 6:11 PM
Unknown Object (File)
Tue, Dec 31, 1:19 AM
Unknown Object (File)
Tue, Dec 31, 1:19 AM
Unknown Object (File)
Tue, Dec 31, 1:15 AM
Unknown Object (File)
Tue, Dec 31, 1:12 AM
Unknown Object (File)
Fri, Dec 27, 3:56 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9135: Unpublished inlines shouldn't be hidable
Commits
Restricted Diffusion Commit
rP51c52f50fdda: Prevent users from hiding unpublished inlines
Summary

Fixes T9135. This is (probably) never intended and can be confusing.

Test Plan

Saw no hide button on unpublished inlines. Saw hide button on published inlines. Clicked hide button.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33890.Aug 31 2015, 1:48 PM
epriestley retitled this revision from to Prevent users from hiding unpublished inlines.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9135: Unpublished inlines shouldn't be hidable.
chad accepted this revision.Aug 31 2015, 2:18 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 31 2015, 2:18 PM
Closed by commit rP51c52f50fdda: Prevent users from hiding unpublished inlines (authored by epriestley, committed by epriestley). · Explain WhyAug 31 2015, 5:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
diff/
view/
37 lines

Diff 33894

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
Phabricator · Built by Phacility