Differential D14014

Prevent users from hiding unpublished inlines
ClosedPublic
Actions

Authored by epriestley on Aug 31 2015, 1:48 PM.

Details

Reviewers

chad

Maniphest Tasks

T9135: Unpublished inlines shouldn't be hidable

Commits

Restricted Diffusion Commit
rP51c52f50fdda: Prevent users from hiding unpublished inlines

Summary

Fixes T9135. This is (probably) never intended and can be confusing.

Test Plan

Saw no hide button on unpublished inlines. Saw hide button on published inlines. Clicked hide button.

Diff Detail

Repository

rP Phabricator

Branch

hide1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7855
Build 8741: [Placeholder Plan] Wait for 30 Seconds
Build 8740: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33890.Aug 31 2015, 1:48 PM

epriestley retitled this revision from to Prevent users from hiding unpublished inlines.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9135: Unpublished inlines shouldn't be hidable.

chad accepted this revision.Aug 31 2015, 2:18 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 31 2015, 2:18 PM

Closed by commit rP51c52f50fdda: Prevent users from hiding unpublished inlines (authored by epriestley, committed by epriestley). · Explain WhyAug 31 2015, 5:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

diff/

view/

PHUIDiffInlineCommentDetailView.php

37 lines

Diff 33890

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Prevent users from hiding unpublished inlinesClosedPublicActions