Differential D13959

Create operator nodes in ternary expressions
ClosedPublic
Actions

Authored by joshuaspence on Aug 22 2015, 1:23 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU33975b2bc75c: Create operator nodes in ternary expressions

Summary

This simplifies D13937.

Test Plan


Before	After

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7820
Build 8672: [Placeholder Plan] Wait for 30 Seconds
Build 8671: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33692.Aug 22 2015, 1:23 AM

joshuaspence retitled this revision from to Create operator nodes in ternary expressions.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 22 2015, 1:23 AM

Herald added a subscriber: Korvin. · View Herald Transcript

joshuaspence edited the test plan for this revision. (Show Details)Aug 22 2015, 1:26 AM

joshuaspence edited edge metadata.

joshuaspence added a child revision: D13961: Fix linter rule after XHPAST change.Aug 22 2015, 1:50 AM

epriestley accepted this revision.Aug 27 2015, 11:26 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 27 2015, 11:26 AM

Rebase

Closed by commit rPHU33975b2bc75c: Create operator nodes in ternary expressions (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 27 2015, 12:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

parser/

xhpast/

__tests__/

data/

base-fail-parse.php.expect

4 lines

base-pass.php.expect

4 lines

php-access-on-instanciation.expect

4 lines

php-array-dereference-2.expect

4 lines

php-array-dereference-3.expect

4 lines

php-binary-literal.php.expect

4 lines

php-callable-typehint.php.expect

4 lines

php-comments.php.expect

4 lines

php-empty-heredoc.php.expect

4 lines

php-finally.php.expect

4 lines

php-heredoc-terminal.php.expect

4 lines

php-literals.php.expect

4 lines

php-syntax.php.expect

20 lines

php-tags.php.expect

4 lines

php-yield.php.expect

4 lines

bin/

PhutilXHPASTBinary.php

2 lines

20%

support/

xhpast/

parser.y

4 lines

parser.yacc.cpp

594 lines

xhpast.cpp

2 lines

Diff 33833

View Options

src/parser/xhpast/tests/data/base-fail-parse.php.expect

View Options

src/parser/xhpast/tests/data/base-pass.php.expect

View Options

src/parser/xhpast/tests/data/php-access-on-instanciation.expect

View Options

src/parser/xhpast/tests/data/php-array-dereference-2.expect

View Options

src/parser/xhpast/tests/data/php-array-dereference-3.expect

View Options

src/parser/xhpast/tests/data/php-binary-literal.php.expect

View Options

src/parser/xhpast/tests/data/php-callable-typehint.php.expect

View Options

src/parser/xhpast/tests/data/php-comments.php.expect

View Options

src/parser/xhpast/tests/data/php-empty-heredoc.php.expect

View Options

src/parser/xhpast/tests/data/php-finally.php.expect

View Options

src/parser/xhpast/tests/data/php-heredoc-terminal.php.expect

View Options

src/parser/xhpast/tests/data/php-literals.php.expect

View Options

src/parser/xhpast/tests/data/php-syntax.php.expect

View Options

src/parser/xhpast/tests/data/php-tags.php.expect

View Options

src/parser/xhpast/tests/data/php-yield.php.expect

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

View Options

support/xhpast/parser.y

View Options

support/xhpast/parser.yacc.cpp

View Options

Create operator nodes in ternary expressionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33833

src/parser/xhpast/__tests__/data/base-fail-parse.php.expect

src/parser/xhpast/__tests__/data/base-pass.php.expect

src/parser/xhpast/__tests__/data/php-access-on-instanciation.expect

src/parser/xhpast/__tests__/data/php-array-dereference-2.expect

src/parser/xhpast/__tests__/data/php-array-dereference-3.expect

src/parser/xhpast/__tests__/data/php-binary-literal.php.expect

src/parser/xhpast/__tests__/data/php-callable-typehint.php.expect

src/parser/xhpast/__tests__/data/php-comments.php.expect

src/parser/xhpast/__tests__/data/php-empty-heredoc.php.expect

src/parser/xhpast/__tests__/data/php-finally.php.expect

src/parser/xhpast/__tests__/data/php-heredoc-terminal.php.expect

src/parser/xhpast/__tests__/data/php-literals.php.expect

src/parser/xhpast/__tests__/data/php-syntax.php.expect

src/parser/xhpast/__tests__/data/php-tags.php.expect

src/parser/xhpast/__tests__/data/php-yield.php.expect

src/parser/xhpast/bin/PhutilXHPASTBinary.php

support/xhpast/parser.y

support/xhpast/parser.yacc.cpp

support/xhpast/xhpast.cpp

Create operator nodes in ternary expressions
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/base-fail-parse.php.expect

src/parser/xhpast/tests/data/base-pass.php.expect

src/parser/xhpast/tests/data/php-access-on-instanciation.expect

src/parser/xhpast/tests/data/php-array-dereference-2.expect

src/parser/xhpast/tests/data/php-array-dereference-3.expect

src/parser/xhpast/tests/data/php-binary-literal.php.expect

src/parser/xhpast/tests/data/php-callable-typehint.php.expect

src/parser/xhpast/tests/data/php-comments.php.expect

src/parser/xhpast/tests/data/php-empty-heredoc.php.expect

src/parser/xhpast/tests/data/php-finally.php.expect

src/parser/xhpast/tests/data/php-heredoc-terminal.php.expect

src/parser/xhpast/tests/data/php-literals.php.expect

src/parser/xhpast/tests/data/php-syntax.php.expect

src/parser/xhpast/tests/data/php-tags.php.expect

src/parser/xhpast/tests/data/php-yield.php.expect