Differential D13968

Improve XHPAST handling of traits
Changes PlannedPublic
Actions

Authored by joshuaspence on Aug 23 2015, 1:55 AM.

Tags

None

Referenced Files

	F19812189: D13968.diff
	Wed, Mar 4, 3:59 AM

	F19067292: D13968.id.diff
	Nov 30 2025, 8:02 AM

	F19061245: D13968.diff
	Nov 29 2025, 11:50 AM

	F18834352: D13968.id.diff
	Oct 26 2025, 8:08 AM

	F18826054: D13968.diff
	Oct 24 2025, 2:19 AM

	F18821407: D13968.id33918.diff
	Oct 22 2025, 10:54 PM

	F18821358: D13968.id33703.diff
	Oct 22 2025, 10:18 PM

	F18759251: D13968.diff
	Oct 6 2025, 2:40 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Summary

Ref T4334.

Test Plan

WIP

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7726
Build 8485: [Placeholder Plan] Wait for 30 Seconds
Build 8483: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	6,126 ms	PHPASTParserTestCase::Unknown Unit Message ("")
	100 ms	PhutilBugtraqParserTestCase::Unknown Unit Message ("")
	45 ms	PhutilDocblockParserTestCase::Unknown Unit Message ("")
	1,711 ms	PhutilEditorConfigTestCase::Unknown Unit Message ("")
	66 ms	PhutilEmailAddressTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 45 Passed)

Event Timeline

joshuaspence updated this revision to Diff 33703.Aug 23 2015, 1:55 AM

joshuaspence retitled this revision from to Improve XHPAST handling of traits.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a task: T4334: Support PHP5.4+ syntax in XHPAST.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 23 2015, 1:55 AM

Herald added a subscriber: epriestley. · View Herald Transcript

WIP

This revision now requires changes to proceed.Aug 27 2015, 11:23 AM

Rebase

Herald added a subscriber: Korvin. · View Herald TranscriptSep 1 2015, 1:32 PM

joshuaspence planned changes to this revision.Sep 1 2015, 1:32 PM

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

parser/

xhpast/

parser_nodes.php

1 line

0%

Loading...

support/

xhpast/

generate_nodes.php

251 lines

-

-

20 lines

-

-

parser.yacc.cpp

5154 lines

-

-

parser_nodes.php

1 line

-

-

Diff 33703

src/parser/xhpast/parser_nodes.php

Loading...

support/xhpast/generate_nodes.php

Loading...

support/xhpast/parser.y

Loading...

support/xhpast/parser.yacc.cpp

Loading...

support/xhpast/parser_nodes.php

Loading...