Paths

Table of Contentst

Diffusion libphutil dc0626970a6d

Don't eat whitespace after T_OPEN_TAG
dc0626970a6d
Actions

Tags

None

Referenced Files

	F764333: xhpast-before.png
	Aug 30 2015, 8:50 PM

	F764335: xhpast-after.png
	Aug 30 2015, 8:50 PM

Subscribers

None

Description

Don't eat whitespace after T_OPEN_TAG

Summary: Currently the scanner eats whitespace after <?php but not after <?. This means that <?php tokenises to T_OPEN_TAG (see https://secure.phabricator.com/xhpast/view/853/) whereas <? tokenises to T_OPEN_TAG, T_WHITESPACE (see https://secure.phabricator.com/xhpast/view/854/).

Test Plan:

Before	After

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D13890

Details

Provenance

joshuaspence	Authored on
joshuaspence	Pushed on Aug 30 2015, 8:50 PM

Reviewer

Blessed Reviewers

Differential Revision

D13890: Don't eat whitespace after T_OPEN_TAG

Parents

rPHUc8a008f7e46c: Make PHP echo tags always available

Branches

Unknown

Tags

Unknown

Event Timeline

joshuaspence committed rPHUdc0626970a6d: Don't eat whitespace after T_OPEN_TAG (authored by joshuaspence).Aug 30 2015, 8:49 PM

Changes (22)

Path

Size

src/

parser/

xhpast/

__tests__/

data/

base-pass.php.expect

php-access-on-instanciation.expect

php-array-dereference-2.expect

php-array-dereference-3.expect

php-array-dereference.expect

php-binary-literal.php.expect

php-callable-typehint.php.expect

php-comments.php.expect

php-empty-heredoc.php.expect

php-finally.php.expect

php-literal-index.php.expect

php-literals.php.expect

php-short-array.php.expect

php-syntax.php.expect

php-tags.php.expect

php-traits.php.expect

php-yield.php.expect

bin/

PhutilXHPASTBinary.php

support/

xhpast/

scanner.lex.cpp

scanner.lex.hpp

rPHUdc0626970a6d

src/parser/xhpast/tests/data/base-pass.php.expect

Loading...

src/parser/xhpast/tests/data/php-access-on-instanciation.expect

Loading...

src/parser/xhpast/tests/data/php-array-dereference-2.expect

Loading...

src/parser/xhpast/tests/data/php-array-dereference-3.expect

Loading...

src/parser/xhpast/tests/data/php-array-dereference.expect

Loading...

src/parser/xhpast/tests/data/php-binary-literal.php.expect

Loading...

src/parser/xhpast/tests/data/php-callable-typehint.php.expect

Loading...

src/parser/xhpast/tests/data/php-comments.php.expect

Loading...

src/parser/xhpast/tests/data/php-empty-heredoc.php.expect

Loading...

src/parser/xhpast/tests/data/php-finally.php.expect

Loading...

src/parser/xhpast/tests/data/php-literal-index.php.expect

Loading...

src/parser/xhpast/tests/data/php-literals.php.expect

Loading...

src/parser/xhpast/tests/data/php-short-array.php.expect

Loading...

src/parser/xhpast/tests/data/php-syntax.php.expect

Loading...

src/parser/xhpast/tests/data/php-tags.php.expect

Loading...

src/parser/xhpast/tests/data/php-traits.php.expect

Loading...

src/parser/xhpast/tests/data/php-yield.php.expect

Loading...

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...

support/xhpast/scanner.l

Loading...

support/xhpast/scanner.lex.cpp

Loading...

support/xhpast/scanner.lex.hpp

Loading...

support/xhpast/xhpast.cpp

Loading...