Page MenuHomePhabricator

Allow Nuance source definitions to add actions to source views
ClosedPublic

Authored by epriestley on Aug 22 2015, 10:40 PM.
Tags
None
Referenced Files
F13149078: D13966.diff
Sat, May 4, 6:32 AM
Unknown Object (File)
Wed, May 1, 1:01 AM
Unknown Object (File)
Mon, Apr 29, 4:07 PM
Unknown Object (File)
Tue, Apr 9, 7:46 PM
Unknown Object (File)
Apr 3 2024, 10:49 PM
Unknown Object (File)
Apr 1 2024, 2:34 AM
Unknown Object (File)
Mar 28 2024, 3:12 PM
Unknown Object (File)
Mar 27 2024, 9:11 PM
Subscribers
None

Details

Summary

Ref T8783. If you have a source (like a "report bug" form), let it put a link (like "View Form") on the source detail page.

This also straightens out getting definitions from sources, which had a bug with the modern way we do PhutilClassMapQuery.

Specifically, if you called the old mechanism on two different sources, they'd return the same definition object, but they need to return different definitions.

Test Plan

Screen Shot 2015-08-22 at 3.38.58 PM.png (718×1 px, 124 KB)

Screen Shot 2015-08-22 at 3.39.01 PM.png (718×1 px, 81 KB)

Diff Detail

Repository
rP Phabricator
Branch
nuance2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7724
Build 8481: [Placeholder Plan] Wait for 30 Seconds
Build 8480: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow Nuance source definitions to add actions to source views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Those screenshots were in the wrong order -- the form already existed, I'm just showing where the link takes you.

chad edited edge metadata.
This revision is now accepted and ready to land.Aug 22 2015, 11:37 PM
This revision was automatically updated to reflect the committed changes.