Page MenuHomePhabricator

Improve linter handling of short array syntax
ClosedPublic

Authored by joshuaspence on Aug 14 2015, 3:26 AM.
Tags
None
Referenced Files
F14406684: D13895.diff
Mon, Dec 23, 7:13 PM
Unknown Object (File)
Sun, Dec 22, 3:47 AM
Unknown Object (File)
Wed, Dec 18, 6:56 PM
Unknown Object (File)
Sat, Dec 14, 1:44 PM
Unknown Object (File)
Fri, Dec 13, 9:09 PM
Unknown Object (File)
Thu, Dec 12, 11:55 AM
Unknown Object (File)
Thu, Dec 12, 12:15 AM
Unknown Object (File)
Thu, Nov 28, 2:15 PM

Details

Summary

Currently, linting PHP short array syntax (i.e. [...]) throws an exception ("Expected open parentheses"). This diff relaxes some restrictions which prevent short array syntax from linting with ArcanistParenthesesSpacingXHPASTLinterRule.

Test Plan

Modified test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7682
Build 8401: [Placeholder Plan] Wait for 30 Seconds
Build 8400: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Improve linter handling of short array syntax.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 14 2015, 10:58 AM
This revision was automatically updated to reflect the committed changes.