Paths

Table of Contentst

Differential D13895

Improve linter handling of short array syntax
ClosedPublic
Actions

Authored by joshuaspence on Aug 14 2015, 3:26 AM.

Tags

None

Referenced Files

	F14406684: D13895.diff
	Mon, Dec 23, 7:13 PM

	Unknown Object (File)
	Sun, Dec 22, 3:47 AM

	Unknown Object (File)
	Wed, Dec 18, 6:56 PM

	Unknown Object (File)
	Sat, Dec 14, 1:44 PM

	Unknown Object (File)
	Fri, Dec 13, 9:09 PM

	Unknown Object (File)
	Thu, Dec 12, 11:55 AM

	Unknown Object (File)
	Thu, Dec 12, 12:15 AM

	Unknown Object (File)
	Thu, Nov 28, 2:15 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC27ec3a2e34aa: Improve linter handling of short array syntax

Summary

Currently, linting PHP short array syntax (i.e. [...]) throws an exception ("Expected open parentheses"). This diff relaxes some restrictions which prevent short array syntax from linting with ArcanistParenthesesSpacingXHPASTLinterRule.

Test Plan

Modified test cases.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7626
Build 8292: [Placeholder Plan] Wait for 30 Seconds
Build 8291: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	123,591 ms	ArcanistXHPASTLinterTestCase::Unknown Unit Message ("")
	332 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	1,979 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	274 ms	ArcanistChmodLinterTestCase::Unknown Unit Message ("")
	95 ms	ArcanistClosureLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 50 Passed · 7 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 33543.Aug 14 2015, 3:26 AM

joshuaspence retitled this revision from to Improve linter handling of short array syntax.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 14 2015, 3:26 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 14 2015, 10:58 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 14 2015, 10:58 AM

agenticarus added a subscriber: agenticarus.Aug 18 2015, 11:10 AM

Rebase

Closed by commit rARC27ec3a2e34aa: Improve linter handling of short array syntax (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 19 2015, 5:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

lint/

linter/

__tests__/

xhpast/

array-formatting.lint-test

4 lines

-

-

xhpast/

rules/

ArcanistCallParenthesesXHPASTLinterRule.php

6 lines

94%

Loading...

ArcanistParenthesesSpacingXHPASTLinterRule.php

6 lines

100%

Loading...

Diff 33543

src/lint/linter/tests/xhpast/array-formatting.lint-test

Loading...

src/lint/linter/xhpast/rules/ArcanistCallParenthesesXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistParenthesesSpacingXHPASTLinterRule.php

Loading...