Page MenuHomePhabricator
Differential D13929

Fix Owners package specificity ordering
ClosedPublic
Actions

Authored by epriestley on Aug 18 2015, 7:12 PM.
Tags
None
Referenced Files
F15527008: D13929.id33619.diff
Tue, Apr 22, 12:03 AM
F15492912: D13929.id33620.diff
Sat, Apr 12, 7:38 PM
F15490735: D13929.id.diff
Fri, Apr 11, 8:05 PM
F15488963: D13929.id33619.diff
Fri, Apr 11, 4:42 AM
F15486212: D13929.diff
Thu, Apr 10, 5:40 AM
F15463504: D13929.id.diff
Wed, Apr 2, 12:17 AM
F15421984: D13929.diff
Mar 22 2025, 4:13 AM
F15415277: D13929.diff
Mar 20 2025, 5:10 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP0a509ea7eceb: Fix Owners package specificity ordering
Summary

This algorithm isn't quite right with respect to ordering more-specific packages correctly.

Test Plan

Screen Shot 2015-08-18 at 12.10.39 PM.png (679×1 px, 120 KB)

Diff Detail

Repository
rP Phabricator
Branch
matchlen
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7667
Build 8372: [Placeholder Plan] Wait for 30 Seconds
Build 8371: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33619.Aug 18 2015, 7:12 PM
epriestley retitled this revision from to Fix Owners package specificity ordering.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Aug 18 2015, 7:12 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 18 2015, 7:12 PM
Closed by commit rP0a509ea7eceb: Fix Owners package specificity ordering (authored by epriestley, committed by epriestley). · Explain WhyAug 18 2015, 7:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
owners/
storage/
7 lines

Diff 33619

View Options

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...
Phabricator · Built by Phacility