Page MenuHomePhabricator
Differential D13929

Fix Owners package specificity ordering
ClosedPublic
Actions

Authored by epriestley on Aug 18 2015, 7:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 2:36 PM
Unknown Object (File)
Mon, Dec 9, 4:24 AM
Unknown Object (File)
Sun, Dec 8, 6:24 PM
Unknown Object (File)
Thu, Dec 5, 12:12 AM
Unknown Object (File)
Wed, Dec 4, 8:48 AM
Unknown Object (File)
Sat, Nov 30, 2:11 PM
Unknown Object (File)
Wed, Nov 27, 11:37 PM
Unknown Object (File)
Nov 20 2024, 2:13 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP0a509ea7eceb: Fix Owners package specificity ordering
Summary

This algorithm isn't quite right with respect to ordering more-specific packages correctly.

Test Plan

Screen Shot 2015-08-18 at 12.10.39 PM.png (679×1 px, 120 KB)

Diff Detail

Repository
rP Phabricator
Branch
matchlen
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7667
Build 8372: [Placeholder Plan] Wait for 30 Seconds
Build 8371: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33619.Aug 18 2015, 7:12 PM
epriestley retitled this revision from to Fix Owners package specificity ordering.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Aug 18 2015, 7:12 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 18 2015, 7:12 PM
Closed by commit rP0a509ea7eceb: Fix Owners package specificity ordering (authored by epriestley, committed by epriestley). · Explain WhyAug 18 2015, 7:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
owners/
storage/
7 lines

Diff 33619

View Options

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...
Phabricator · Built by Phacility