Page MenuHomePhabricator
Differential D13875

Clean up some Ponder language
ClosedPublic
Actions

Authored by chad on Aug 12 2015, 4:25 AM.
Tags
None
Referenced Files
F13218001: D13875.id.diff
Sat, May 18, 9:20 AM
F13207563: D13875.diff
Thu, May 16, 1:02 AM
F13206811: D13875.id33508.diff
Wed, May 15, 5:59 PM
Unknown Object (File)
Thu, Apr 25, 3:29 AM
Unknown Object (File)
Apr 19 2024, 4:59 AM
Unknown Object (File)
Apr 6 2024, 12:28 PM
Unknown Object (File)
Mar 2 2024, 5:05 PM
Unknown Object (File)
Feb 9 2024, 1:05 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9099: Redesign Ponder
Commits
Restricted Diffusion Commit
rP9a7beadd22f0: Clean up some Ponder language
Summary

Ref T9099.

  • Remove unused function
  • Fix celerity resource include
  • Add a note when an answer's been closed
  • Clean up architecture a little
  • Add a better notice when you've already answered.
Test Plan

Test with and without answers, with answering, with being closed.

Diff Detail

Repository
rP Phabricator
Branch
close-no-answer
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7601
Build 8242: [Placeholder Plan] Wait for 30 Seconds
Build 8241: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33504.Aug 12 2015, 4:25 AM
chad retitled this revision from to Clean up some Ponder language.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9099: Redesign Ponder.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 12 2015, 4:25 AM
epriestley accepted this revision.Aug 12 2015, 1:36 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 12 2015, 1:36 PM
Closed by commit rP9a7beadd22f0: Clean up some Ponder language (authored by chad, committed by chad). · Explain WhyAug 12 2015, 2:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
ponder/
constants/
2 lines
controller/
62 lines
view/
30 lines
1 line

Diff 33504

View Options

src/applications/ponder/constants/PonderQuestionStatus.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionViewController.php

Loading...
View Options

src/applications/ponder/view/PonderAddAnswerView.php

Loading...
View Options

src/applications/ponder/view/PonderFooterView.php

Loading...
Phabricator · Built by Phacility