Page MenuHomePhabricator
Differential D13875

Clean up some Ponder language
ClosedPublic
Actions

Authored by chad on Aug 12 2015, 4:25 AM.
Tags
None
Referenced Files
F14011881: D13875.id33508.diff
Fri, Nov 1, 5:33 AM
F14001947: D13875.diff
Fri, Oct 25, 1:30 PM
F14001943: D13875.id.diff
Fri, Oct 25, 1:26 PM
F14001940: D13875.id33504.diff
Fri, Oct 25, 1:25 PM
F14001932: D13875.id33508.diff
Fri, Oct 25, 1:23 PM
F13984163: D13875.id33504.diff
Sun, Oct 20, 11:25 AM
Unknown Object (File)
Fri, Oct 11, 10:25 PM
Unknown Object (File)
Sep 27 2024, 8:37 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9099: Redesign Ponder
Commits
Restricted Diffusion Commit
rP9a7beadd22f0: Clean up some Ponder language
Summary

Ref T9099.

  • Remove unused function
  • Fix celerity resource include
  • Add a note when an answer's been closed
  • Clean up architecture a little
  • Add a better notice when you've already answered.
Test Plan

Test with and without answers, with answering, with being closed.

Diff Detail

Repository
rP Phabricator
Branch
close-no-answer
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7601
Build 8242: [Placeholder Plan] Wait for 30 Seconds
Build 8241: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33504.Aug 12 2015, 4:25 AM
chad retitled this revision from to Clean up some Ponder language.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9099: Redesign Ponder.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 12 2015, 4:25 AM
epriestley accepted this revision.Aug 12 2015, 1:36 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 12 2015, 1:36 PM
Closed by commit rP9a7beadd22f0: Clean up some Ponder language (authored by chad, committed by chad). · Explain WhyAug 12 2015, 2:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
ponder/
constants/
2 lines
controller/
62 lines
view/
30 lines
1 line

Diff 33504

View Options

src/applications/ponder/constants/PonderQuestionStatus.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionViewController.php

Loading...
View Options

src/applications/ponder/view/PonderAddAnswerView.php

Loading...
View Options

src/applications/ponder/view/PonderFooterView.php

Loading...
Phabricator · Built by Phacility