Page MenuHomePhabricator
Differential D13861

Various linter fixes
ClosedPublic
Actions

Authored by joshuaspence on Aug 11 2015, 11:54 AM.
Tags
None
Referenced Files
F19634918: D13861.diff
Thu, Feb 5, 9:23 AM
F18871419: D13861.id33487.diff
Nov 4 2025, 10:38 PM
F18833066: D13861.id.diff
Oct 26 2025, 12:33 AM
F18827046: D13861.diff
Oct 24 2025, 7:19 AM
F18818334: D13861.id33477.diff
Oct 21 2025, 11:32 PM
F18712681: D13861.id.diff
Sep 29 2025, 5:30 AM
F18622518: D13861.id33477.diff
Sep 15 2025, 12:08 PM
F18604069: D13861.id33487.diff
Sep 13 2025, 5:54 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCe00e2939c164: Various linter fixes
Summary

Self explanatory.

Test Plan

arc lint

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7585
Build 8210: [Placeholder Plan] Wait for 30 Seconds
Build 8209: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33477.Aug 11 2015, 11:54 AM
joshuaspence retitled this revision from to Various linter fixes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 11 2015, 11:55 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 11 2015, 12:28 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2015, 12:28 PM
Closed by commit rARCe00e2939c164: Various linter fixes (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 11 2015, 12:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
lint/
linter/
__tests__/
2 lines0%
Loading...
parser/
95 lines64%
Loading...
repository/
api/
6 lines13%
Loading...

Diff 33477

View Options

src/lint/linter/__tests__/ArcanistLinterTestCase.php

Loading...
View Options

src/parser/ArcanistBundle.php

Loading...
View Options

src/repository/api/ArcanistMercurialAPI.php

Loading...
Phabricator · Built by Phacility