Paths

Table of Contentst

Differential D13860

Fix failing JSHint linter test
ClosedPublic
Actions

Authored by joshuaspence on Aug 11 2015, 11:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 22, 2:51 AM

	Unknown Object (File)
	Mon, Dec 2, 12:28 PM

	Unknown Object (File)
	Mon, Nov 25, 5:03 PM

	Unknown Object (File)
	Nov 20 2024, 10:27 AM

	Unknown Object (File)
	Nov 16 2024, 5:10 AM

	Unknown Object (File)
	Nov 11 2024, 4:19 PM

	Unknown Object (File)
	Nov 8 2024, 11:13 AM

	Unknown Object (File)
	Nov 8 2024, 12:45 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCb82e4cd40e1f: Fix failing JSHint linter test

Summary

This test case is failing on JSHint v2.8.0.

Test Plan

arc unit

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7584
Build 8208: [Placeholder Plan] Wait for 30 Seconds
Build 8207: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33476.Aug 11 2015, 11:44 AM

joshuaspence retitled this revision from to Fix failing JSHint linter test.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 11 2015, 11:44 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 11 2015, 12:28 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 11 2015, 12:28 PM

Closed by commit rARCb82e4cd40e1f: Fix failing JSHint linter test (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 11 2015, 12:34 PM

This revision was automatically updated to reflect the committed changes.

this change causes jshint 2.7.0 to break. Your change anticipates jshint erroring on the ~~~~~ line, but this is the only test in this directory that does that. The answer to the breakage I'm seeing might just be "use the latest version of jshint", but I just wanted to double check the inconsistency and the use of an error for a line that's not part of the code.

Yeah, we don't really have a way to run version-specific unit tests at the moment (see T4954).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

jshint/

jshint.lint-test

1 line

Diff 33476

src/lint/linter/tests/jshint/jshint.lint-test

Loading...