Page MenuHomePhabricator

Fix failing JSHint linter test
ClosedPublic

Authored by joshuaspence on Aug 11 2015, 11:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 6:59 PM
Unknown Object (File)
Apr 2 2024, 7:04 AM
Unknown Object (File)
Mar 23 2024, 1:08 PM
Unknown Object (File)
Feb 3 2024, 6:15 AM
Unknown Object (File)
Jan 28 2024, 8:07 AM
Unknown Object (File)
Jan 28 2024, 8:07 AM
Unknown Object (File)
Jan 28 2024, 8:07 AM
Unknown Object (File)
Jan 28 2024, 8:07 AM
Subscribers

Details

Summary

This test case is failing on JSHint v2.8.0.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7584
Build 8208: [Placeholder Plan] Wait for 30 Seconds
Build 8207: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Fix failing JSHint linter test.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2015, 12:28 PM
This revision was automatically updated to reflect the committed changes.

this change causes jshint 2.7.0 to break. Your change anticipates jshint erroring on the ~~~~~ line, but this is the only test in this directory that does that. The answer to the breakage I'm seeing might just be "use the latest version of jshint", but I just wanted to double check the inconsistency and the use of an error for a line that's not part of the code.

Yeah, we don't really have a way to run version-specific unit tests at the moment (see T4954).