Read synthetic inline comments from Harbormaster
ClosedPublic
Actions

Authored by epriestley on Aug 10 2015, 7:26 PM.

Tags

None

Referenced Files

	F16818885: D13847.diff
	Wed, Jun 18, 6:26 AM

	F16691156: D13847.diff
	Tue, Jun 17, 3:40 PM

	Unknown Object (File)
	Tue, Jun 17, 3:33 AM

	Unknown Object (File)
	Apr 23 2025, 9:29 AM

	Unknown Object (File)
	Apr 22 2025, 10:21 PM

	Unknown Object (File)
	Apr 22 2025, 9:30 AM

	Unknown Object (File)
	Apr 21 2025, 5:30 AM

	Unknown Object (File)
	Apr 19 2025, 11:40 PM

View All Files

Subscribers

None

Tokens

"Doubloon" token, awarded by joshuaspence.

Details

Reviewers

chad

Maniphest Tasks

T8096: Improve Harbormaster UI/UX (v1)

Commits

Restricted Diffusion Commit
rP2b13da88ceb9: Read synthetic inline comments from Harbormaster

Summary

Ref T8096. These are still reading out of the old diff property, but should read from Harbormaster instead.

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33435.Aug 10 2015, 7:26 PM

epriestley retitled this revision from to Read synthetic inline comments from Harbormaster.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T8096: Improve Harbormaster UI/UX (v1).

chad accepted this revision.Aug 10 2015, 7:42 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 10 2015, 7:42 PM

joshuaspence awarded a token.Aug 10 2015, 8:35 PM

Closed by commit rP2b13da88ceb9: Read synthetic inline comments from Harbormaster (authored by epriestley, committed by epriestley). · Explain WhyAug 10 2015, 9:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialChangesetViewController.php

76 lines

Diff 33453

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Read synthetic inline comments from HarbormasterClosedPublicActions