Read synthetic inline comments from Harbormaster
ClosedPublic
Actions

Authored by epriestley on Aug 10 2015, 7:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 1, 12:08 AM

	Unknown Object (File)
	Thu, Apr 11, 9:00 AM

	Unknown Object (File)
	Tue, Apr 9, 2:34 AM

	Unknown Object (File)
	Fri, Apr 5, 11:54 AM

	Unknown Object (File)
	Mar 28 2024, 5:00 AM

	Unknown Object (File)
	Feb 20 2024, 4:58 AM

	Unknown Object (File)
	Feb 9 2024, 12:31 PM

	Unknown Object (File)
	Feb 9 2024, 9:37 AM

View All Files

Subscribers

None

Tokens

"Doubloon" token, awarded by joshuaspence.

Details

Reviewers

chad

Maniphest Tasks

T8096: Improve Harbormaster UI/UX (v1)

Commits

Restricted Diffusion Commit
rP2b13da88ceb9: Read synthetic inline comments from Harbormaster

Summary

Ref T8096. These are still reading out of the old diff property, but should read from Harbormaster instead.

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

harbor4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7564
Build 8168: [Placeholder Plan] Wait for 30 Seconds
Build 8167: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33435.Aug 10 2015, 7:26 PM

epriestley retitled this revision from to Read synthetic inline comments from Harbormaster.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T8096: Improve Harbormaster UI/UX (v1).

chad accepted this revision.Aug 10 2015, 7:42 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 10 2015, 7:42 PM

joshuaspence awarded a token.Aug 10 2015, 8:35 PM

Closed by commit rP2b13da88ceb9: Read synthetic inline comments from Harbormaster (authored by epriestley, committed by epriestley). · Explain WhyAug 10 2015, 9:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialChangesetViewController.php

76 lines

Diff 33435

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Read synthetic inline comments from HarbormasterClosedPublicActions