Page MenuHomePhabricator
Differential D13852

Read modern coverage information for tables of contents
ClosedPublic
Actions

Authored by epriestley on Aug 10 2015, 9:00 PM.
Tags
None
Referenced Files
F13135882: D13852.diff
Thu, May 2, 11:12 AM
Unknown Object (File)
Thu, Apr 25, 1:48 AM
Unknown Object (File)
Fri, Apr 12, 9:12 PM
Unknown Object (File)
Mar 24 2024, 9:34 PM
Unknown Object (File)
Mar 24 2024, 8:16 PM
Unknown Object (File)
Mar 21 2024, 9:42 AM
Unknown Object (File)
Feb 22 2024, 12:17 AM
Unknown Object (File)
Feb 22 2024, 12:17 AM
View All Files
Subscribers
None
Tokens
"Pterodactyl" token, awarded by joshuaspence.

Details

Reviewers
chad
Maniphest Tasks
T8096: Improve Harbormaster UI/UX (v1)
Commits
Restricted Diffusion Commit
rP5485fb8aa9e7: Read modern coverage information for tables of contents
Summary

Ref T8096. This modernizes the last thing which was reading the old datasource.

Also fix a bug where it didn't work.

Test Plan

Screen Shot 2015-08-10 at 1.55.02 PM.png (180×1 px, 27 KB)

Diff Detail

Repository
rP Phabricator
Branch
harbor7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7570
Build 8180: [Placeholder Plan] Wait for 30 Seconds
Build 8179: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33446.Aug 10 2015, 9:00 PM
epriestley retitled this revision from to Read modern coverage information for tables of contents.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8096: Improve Harbormaster UI/UX (v1).
joshuaspence awarded a token.Aug 10 2015, 9:43 PM
chad accepted this revision.Aug 10 2015, 10:20 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2015, 10:20 PM
Closed by commit rP5485fb8aa9e7: Read modern coverage information for tables of contents (authored by epriestley, committed by epriestley). · Explain WhyAug 10 2015, 10:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33446

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialDiffViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/storage/DifferentialDiff.php

Loading...
View Options

src/applications/differential/view/DifferentialDiffTableOfContentsView.php

Loading...
Phabricator · Built by Phacility