Page MenuHomePhabricator
Differential D13850

Read Differential changeset coverage information from Harbormaster
ClosedPublic
Actions

Authored by epriestley on Aug 10 2015, 8:36 PM.
Tags
None
Referenced Files
F14043027: D13850.id33455.diff
Tue, Nov 12, 7:21 AM
F14022567: D13850.id33439.diff
Wed, Nov 6, 6:20 PM
F14022566: D13850.diff
Wed, Nov 6, 6:20 PM
F14001821: D13850.diff
Fri, Oct 25, 12:19 PM
F14001809: D13850.id.diff
Fri, Oct 25, 12:11 PM
F14001807: D13850.id33439.diff
Fri, Oct 25, 12:10 PM
F14001805: D13850.id33455.diff
Fri, Oct 25, 12:08 PM
F14000634: D13850.id33455.diff
Thu, Oct 24, 11:20 PM
View All Files
Subscribers
None
Tokens
"Doubloon" token, awarded by joshuaspence.

Details

Reviewers
chad
Maniphest Tasks
T8096: Improve Harbormaster UI/UX (v1)
Commits
Restricted Diffusion Commit
rPefa8855e0308: Read Differential changeset coverage information from Harbormaster
Summary

Ref T8096. This information has moved into Harbormaster.

Test Plan

Pushed some test results in; see right margin:

Screen Shot 2015-08-10 at 1.35.39 PM.png (416×869 px, 57 KB)

Diff Detail

Repository
rP Phabricator
Branch
harbor6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7568
Build 8176: [Placeholder Plan] Wait for 30 Seconds
Build 8175: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33439.Aug 10 2015, 8:36 PM
epriestley retitled this revision from to Read Differential changeset coverage information from Harbormaster.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8096: Improve Harbormaster UI/UX (v1).
joshuaspence awarded a token.Aug 10 2015, 8:36 PM
epriestley added a comment.Aug 10 2015, 8:37 PM

Oops, this screenshot actually shows the feature working:

Screen Shot 2015-08-10 at 1.35.39 PM.png (416×869 px, 57 KB)

epriestley edited the test plan for this revision. (Show Details)Aug 10 2015, 8:37 PM
chad accepted this revision.Aug 10 2015, 8:58 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2015, 8:58 PM
Closed by commit rPefa8855e0308: Read Differential changeset coverage information from Harbormaster (authored by epriestley, committed by epriestley). · Explain WhyAug 10 2015, 9:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
104 lines
customfield/
19 lines
storage/
16 lines

Diff 33439

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
View Options

src/applications/differential/customfield/DifferentialHarbormasterField.php

Loading...
View Options

src/applications/differential/storage/DifferentialDiff.php

Loading...
Phabricator · Built by Phacility