Page MenuHomePhabricator

Remove some obsolete lint and unit support
ClosedPublic

Authored by epriestley on Aug 10 2015, 8:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 2:32 AM
Unknown Object (File)
Thu, Jan 30, 2:32 AM
Unknown Object (File)
Thu, Jan 30, 2:32 AM
Unknown Object (File)
Wed, Jan 29, 4:52 PM
Unknown Object (File)
Sun, Jan 26, 5:55 PM
Unknown Object (File)
Sun, Jan 26, 2:32 PM
Unknown Object (File)
Sat, Jan 25, 7:16 PM
Unknown Object (File)
Fri, Jan 24, 7:59 AM
Subscribers
None

Details

Summary

Ref T8096.

Long ago, support for "postponed" lint and unit tests got hacked in. arc would publish a bunch of ghost results, and then something else would fill the results in later.

This was always a hack. It is not nearly as powerful or flexible as having a real build system, and is obsolete with Harbormaster, which supports these operations in a more reasonable and straightforward way.

This was used (only? almost only?) at Facebook.

  • Remove differential.finishpostponedlinters. This only served to update postponed linters.
  • Remove lint magic in differential.setdiffproperty. This magic only made sense in the context of postponed linters.
  • Remove differential.updateunitresults. The only made sense for postponed unit tests.

And one minor change: when a diff contains >100 affected files, we hide the content by default, but show content for files with inline comments. Previously, we'd do this for lint inlines, too. I don't tink this is too useful, and it's much simpler to just remove it. We could add it back at some point, but I think large changes often trigger a lot of lint and no one actually cares. The behavior for actual human inlines is retained.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Branch
harbor5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7565
Build 8170: [Placeholder Plan] Wait for 30 Seconds
Build 8169: arc lint + arc unit