Page MenuHomePhabricator

Remove some obsolete lint and unit support
ClosedPublic

Authored by epriestley on Aug 10 2015, 8:10 PM.
Tags
None
Referenced Files
F14039574: D13848.id33454.diff
Mon, Nov 11, 5:57 AM
F14039573: D13848.id.diff
Mon, Nov 11, 5:57 AM
F14039572: D13848.diff
Mon, Nov 11, 5:57 AM
F14024547: D13848.id33436.diff
Thu, Nov 7, 10:42 AM
F14023861: D13848.id33454.diff
Thu, Nov 7, 3:51 AM
F14023858: D13848.id.diff
Thu, Nov 7, 3:50 AM
F14023857: D13848.diff
Thu, Nov 7, 3:50 AM
F14022559: D13848.id33436.diff
Wed, Nov 6, 6:19 PM
Subscribers
None

Details

Summary

Ref T8096.

Long ago, support for "postponed" lint and unit tests got hacked in. arc would publish a bunch of ghost results, and then something else would fill the results in later.

This was always a hack. It is not nearly as powerful or flexible as having a real build system, and is obsolete with Harbormaster, which supports these operations in a more reasonable and straightforward way.

This was used (only? almost only?) at Facebook.

  • Remove differential.finishpostponedlinters. This only served to update postponed linters.
  • Remove lint magic in differential.setdiffproperty. This magic only made sense in the context of postponed linters.
  • Remove differential.updateunitresults. The only made sense for postponed unit tests.

And one minor change: when a diff contains >100 affected files, we hide the content by default, but show content for files with inline comments. Previously, we'd do this for lint inlines, too. I don't tink this is too useful, and it's much simpler to just remove it. We could add it back at some point, but I think large changes often trigger a lot of lint and no one actually cares. The behavior for actual human inlines is retained.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable