Page MenuHomePhabricator
Differential D13847

Read synthetic inline comments from Harbormaster
ClosedPublic
Actions

Authored by epriestley on Aug 10 2015, 7:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 23 2025, 9:29 AM
Unknown Object (File)
Apr 22 2025, 10:21 PM
Unknown Object (File)
Apr 22 2025, 9:30 AM
Unknown Object (File)
Apr 21 2025, 5:30 AM
Unknown Object (File)
Apr 19 2025, 11:40 PM
Unknown Object (File)
Apr 16 2025, 8:15 PM
Unknown Object (File)
Apr 6 2025, 5:54 AM
Unknown Object (File)
Apr 6 2025, 12:44 AM
View All Files
Subscribers
None
Tokens
"Doubloon" token, awarded by joshuaspence.

Details

Reviewers
chad
Maniphest Tasks
T8096: Improve Harbormaster UI/UX (v1)
Commits
Restricted Diffusion Commit
rP2b13da88ceb9: Read synthetic inline comments from Harbormaster
Summary

Ref T8096. These are still reading out of the old diff property, but should read from Harbormaster instead.

Test Plan

Screen Shot 2015-08-10 at 12.24.45 PM.png (179×879 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Branch
harbor4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7564
Build 8168: [Placeholder Plan] Wait for 30 Seconds
Build 8167: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33435.Aug 10 2015, 7:26 PM
epriestley retitled this revision from to Read synthetic inline comments from Harbormaster.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8096: Improve Harbormaster UI/UX (v1).
chad accepted this revision.Aug 10 2015, 7:42 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2015, 7:42 PM
joshuaspence awarded a token.Aug 10 2015, 8:35 PM
Closed by commit rP2b13da88ceb9: Read synthetic inline comments from Harbormaster (authored by epriestley, committed by epriestley). · Explain WhyAug 10 2015, 9:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
76 lines

Diff 33435

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
Phabricator · Built by Phacility