Updates Projects to use handleRequest
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T8628: Modernize AphrontControllers to implement handleRequest
- Commits
- Restricted Diffusion Commit
rP44f18cfb12d0: Update Project for handleRequest
New Project, Edit Project, Archive, Watch, Create Workboards, Import Workboards, Edit Column, New Column, Change Icon, Add/Remove Members
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- process-project
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 7538 Build 8116: [Placeholder Plan] Wait for 30 Seconds Build 8115: arc lint + arc unit
Event Timeline
| src/applications/project/controller/PhabricatorProjectBoardImportController.php | ||
|---|---|---|
| 8 | By convention, consider separating words with underscores in lowercase variable names: $project_id. | |
| src/applications/project/controller/PhabricatorProjectColumnDetailController.php | ||
| 9 | Yeah, this one's a little more consistent with the rest of the codebase I think. | |
| src/applications/project/controller/PhabricatorProjectListController.php | ||
| 12 | Really minor, but consider $query_key for similar reasons. | |