Page MenuHomePhabricator
Differential D13812

Prevent Harbormaster autobuilds from being stopped, paused or restarted
ClosedPublic
Actions

Authored by epriestley on Aug 6 2015, 3:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 8:25 PM
Unknown Object (File)
Thu, Dec 5, 4:36 AM
Unknown Object (File)
Wed, Dec 4, 11:24 AM
Unknown Object (File)
Tue, Dec 3, 11:22 AM
Unknown Object (File)
Wed, Nov 27, 9:25 AM
Unknown Object (File)
Fri, Nov 22, 6:49 AM
Unknown Object (File)
Thu, Nov 21, 8:22 PM
Unknown Object (File)
Wed, Nov 20, 2:06 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8657: Harbormaster v1 Errata
Commits
Restricted Diffusion Commit
rP580790cd6e35: Prevent Harbormaster autobuilds from being stopped, paused or restarted
Summary

Fixes T8657. "Auto" builds are pushed into Harbormaster by an external system (currently, arc) so it does not make sense to stop or resume them: Harbormaster has no way to control the external system.

Test Plan
  • Tried to restart an autobuild, got an error.
  • Restarted a normal build.
  • Did "Restart All" on a buildable, got restarts on non-autoplans and no restarts on autoplans.

Diff Detail

Repository
rP Phabricator
Branch
harbor4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7513
Build 8066: [Placeholder Plan] Wait for 30 Seconds
Build 8065: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33355.Aug 6 2015, 3:36 PM
epriestley retitled this revision from to Prevent Harbormaster autobuilds from being stopped, paused or restarted.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8657: Harbormaster v1 Errata.
chad accepted this revision.Aug 6 2015, 3:39 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 6 2015, 3:39 PM
Closed by commit rP580790cd6e35: Prevent Harbormaster autobuilds from being stopped, paused or restarted (authored by epriestley, committed by epriestley). · Explain WhyAug 6 2015, 4:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
storage/
build/
16 lines

Diff 33355

View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...
Phabricator · Built by Phacility