Prevent Harbormaster autobuilds from being stopped, paused or restarted
ClosedPublic
Actions

Authored by epriestley on Aug 6 2015, 3:36 PM.

Details

Reviewers

chad

Maniphest Tasks

T8657: Harbormaster v1 Errata

Commits

Restricted Diffusion Commit
rP580790cd6e35: Prevent Harbormaster autobuilds from being stopped, paused or restarted

Summary

Fixes T8657. "Auto" builds are pushed into Harbormaster by an external system (currently, arc) so it does not make sense to stop or resume them: Harbormaster has no way to control the external system.

Test Plan

Tried to restart an autobuild, got an error.
Restarted a normal build.
Did "Restart All" on a buildable, got restarts on non-autoplans and no restarts on autoplans.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 33355.Aug 6 2015, 3:36 PM

epriestley retitled this revision from to Prevent Harbormaster autobuilds from being stopped, paused or restarted.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T8657: Harbormaster v1 Errata.

chad accepted this revision.Aug 6 2015, 3:39 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 6 2015, 3:39 PM

Closed by commit rP580790cd6e35: Prevent Harbormaster autobuilds from being stopped, paused or restarted (authored by epriestley, committed by epriestley). · Explain WhyAug 6 2015, 4:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

storage/

build/

HarbormasterBuild.php

16 lines

Diff 33357

View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Prevent Harbormaster autobuilds from being stopped, paused or restartedClosedPublicActions