Page MenuHomePhabricator
Differential D13806

Various linter fixes
ClosedPublic
Actions

Authored by joshuaspence on Aug 6 2015, 2:06 AM.
Tags
None
Referenced Files
F13285581: D13806.diff
Mon, Jun 3, 11:12 PM
F13281093: D13806.diff
Sun, Jun 2, 9:43 AM
F13268134: D13806.diff
Wed, May 29, 4:41 AM
F13253633: D13806.diff
Sat, May 25, 2:49 AM
F13250250: D13806.diff
Fri, May 24, 1:29 PM
F13231742: D13806.diff
Tue, May 21, 12:45 AM
F13226966: D13806.id33346.diff
Mon, May 20, 12:27 AM
F13186341: D13806.diff
Sat, May 11, 3:34 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU80b79a9f2f33: (stable) Promote 2015 Week 32
rPHU55f554b618b9: Various linter fixes
Summary

Self-explanatory.

Test Plan

Eyeball it.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorresources/test/diverse_symbols.php:17XHP45PHP Compatibility
Errorresources/test/diverse_symbols.php:23XHP3Use of Variable Variable
Unit
Tests Passed
Build Status
Buildable 7506
Build 8052: [Placeholder Plan] Wait for 30 Seconds
Build 8051: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33346.Aug 6 2015, 2:06 AM
joshuaspence retitled this revision from to Various linter fixes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 6 2015, 2:06 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 6 2015, 2:06 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 6 2015, 2:06 AM
Closed by commit rPHU55f554b618b9: Various linter fixes (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 6 2015, 2:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
resources/
test/
14 lines--
src/
utils/
__tests__/
2 lines99%
Loading...
2 lines74%
Loading...

Diff 33346

View Options

resources/test/diverse_symbols.php

Loading...
View Options

src/utils/__tests__/PhutilUtilsTestCase.php

Loading...
View Options

src/utils/utf8.php

Loading...
Phabricator · Built by Phacility