Paths

Table of Contentst

Differential D13795

Improve undeclared variables linter rule
ClosedPublic
Actions

Authored by joshuaspence on Aug 5 2015, 8:44 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCbf4e7d4ca89a: Improve undeclared variables linter rule

Summary

Currently ArcanistUndeclaredVariableXHPASTLinterRule does not properly handle anonymous closures.

Test Plan

Added test cases.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33317.Aug 5 2015, 8:44 AM

joshuaspence retitled this revision from to Improve undeclared variables linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 5 2015, 8:44 AM

Herald added a subscriber: Korvin. · View Herald Transcript

johnny-bit added a subscriber: johnny-bit.Aug 5 2015, 9:45 AM

epriestley accepted this revision.Aug 5 2015, 1:21 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 5 2015, 1:21 PM

Closed by commit rARCbf4e7d4ca89a: Improve undeclared variables linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 5 2015, 8:57 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D13938: Exclude variables used in strings inside closures when checking for undeclared variables.Aug 19 2015, 9:23 AM

joshuaspence mentioned this in rARC9b8c9d280ea4: Exclude variables used in strings inside closures when checking for….Aug 20 2015, 9:27 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

xhpast/

undeclared-variables.lint-test

8 lines

xhpast/

rules/

ArcanistUndeclaredVariableXHPASTLinterRule.php

11 lines

Diff 33335

View Options

src/lint/linter/tests/xhpast/undeclared-variables.lint-test

View Options

src/lint/linter/xhpast/rules/ArcanistUndeclaredVariableXHPASTLinterRule.php

Improve undeclared variables linter ruleClosedPublicActions