Paths

Table of Contentst

Differential D13795

Improve undeclared variables linter rule
ClosedPublic
Actions

Authored by joshuaspence on Aug 5 2015, 8:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 11, 5:38 AM

	Unknown Object (File)
	Mon, Nov 11, 5:37 AM

	Unknown Object (File)
	Mon, Nov 11, 5:36 AM

	Unknown Object (File)
	Mon, Nov 11, 5:35 AM

	Unknown Object (File)
	Thu, Nov 7, 3:40 AM

	Unknown Object (File)
	Thu, Nov 7, 3:40 AM

	Unknown Object (File)
	Thu, Nov 7, 3:40 AM

	Unknown Object (File)
	Thu, Nov 7, 3:39 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCbf4e7d4ca89a: Improve undeclared variables linter rule

Summary

Currently ArcanistUndeclaredVariableXHPASTLinterRule does not properly handle anonymous closures.

Test Plan

Added test cases.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 7490
Build 8020: [Placeholder Plan] Wait for 30 Seconds
Build 8019: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	2,281 ms	ArcanistJSHintLinterTestCase::Unknown Unit Message ("")
	248 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	1,053 ms	ArcanistCSSLintLinterTestCase::Unknown Unit Message ("")
	276 ms	ArcanistChmodLinterTestCase::Unknown Unit Message ("")
	39 ms	ArcanistClosureLinterTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 50 Passed · 7 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 33317.Aug 5 2015, 8:44 AM

joshuaspence retitled this revision from to Improve undeclared variables linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 5 2015, 8:44 AM

Herald added a subscriber: Korvin. · View Herald Transcript

johnny-bit added a subscriber: johnny-bit.Aug 5 2015, 9:45 AM

epriestley accepted this revision.Aug 5 2015, 1:21 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 5 2015, 1:21 PM

Closed by commit rARCbf4e7d4ca89a: Improve undeclared variables linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 5 2015, 8:57 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D13938: Exclude variables used in strings inside closures when checking for undeclared variables.Aug 19 2015, 9:23 AM

joshuaspence mentioned this in rARC9b8c9d280ea4: Exclude variables used in strings inside closures when checking for….Aug 20 2015, 9:27 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

lint/

linter/

__tests__/

xhpast/

undeclared-variables.lint-test

8 lines

-

-

xhpast/

rules/

ArcanistUndeclaredVariableXHPASTLinterRule.php

11 lines

100%

Loading...

Diff 33317

src/lint/linter/tests/xhpast/undeclared-variables.lint-test

Loading...

src/lint/linter/xhpast/rules/ArcanistUndeclaredVariableXHPASTLinterRule.php

Loading...