Differential D13782

Fix some copy/paste slop with BLOCK actions in Herald transcripts
ClosedPublic
Actions

Authored by epriestley on Aug 4 2015, 8:20 AM.

Details

Reviewers

chad

Maniphest Tasks

T9060: Herald Transcript error after updating Phabricator

Commits

Restricted Diffusion Commit
rP386d2b62f819: Fix some copy/paste slop with BLOCK actions in Herald transcripts

Summary

Fixes T9060. These actions still work fine, but the transcripts got messed up a bit.

Test Plan

Viewed transcripts with blocking actions.

Diff Detail

Repository

rP Phabricator

Branch

blockxscript

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7476
Build 7992: [Placeholder Plan] Wait for 30 Seconds
Build 7991: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33288.Aug 4 2015, 8:20 AM

epriestley retitled this revision from to Fix some copy/paste slop with BLOCK actions in Herald transcripts.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9060: Herald Transcript error after updating Phabricator.

chad accepted this revision.Aug 4 2015, 1:44 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 4 2015, 1:44 PM

Closed by commit rP386d2b62f819: Fix some copy/paste slop with BLOCK actions in Herald transcripts (authored by epriestley, committed by epriestley). · Explain WhyAug 4 2015, 2:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

herald/

DifferentialBlockHeraldAction.php

2 lines

diffusion/

herald/

DiffusionBlockHeraldAction.php

2 lines

Diff 33288

View Options

src/applications/differential/herald/DifferentialBlockHeraldAction.php